Commit 165a7f5d authored by Tristram Ha's avatar Tristram Ha Committed by Jakub Kicinski
Browse files

net: dsa: microchip: Fix wrong rx drop MIB counter for KSZ8863 



When KSZ8863 support was first added to KSZ driver the RX drop MIB
counter was somehow defined as 0x105.  The TX drop MIB counter
starts at 0x100 for port 1, 0x101 for port 2, and 0x102 for port 3, so
the RX drop MIB counter should start at 0x103 for port 1, 0x104 for
port 2, and 0x105 for port 3.

There are 5 ports for KSZ8895, so its RX drop MIB counter starts at
0x105.

Fixes: 4b20a07e ("net: dsa: microchip: ksz8795: add support for ksz88xx chips")
Signed-off-by: default avatarTristram Ha <tristram.ha@microchip.com>
Reviewed-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Link: https://patch.msgid.link/20250723030403.56878-1-Tristram.Ha@microchip.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0d9cfc9b

drivers/net/dsa/microchip/ksz8.c

+3 −0
Original line number Diff line number Diff line
@@ -371,6 +371,9 @@ static void ksz8863_r_mib_pkt(struct ksz_device *dev, int port, u16 addr, 
	addr -= dev->info->reg_mib_cnt;

	ctrl_addr = addr ? KSZ8863_MIB_PACKET_DROPPED_TX_0 :

			   KSZ8863_MIB_PACKET_DROPPED_RX_0;

	if (ksz_is_8895_family(dev) &&

	    ctrl_addr == KSZ8863_MIB_PACKET_DROPPED_RX_0)

		ctrl_addr = KSZ8895_MIB_PACKET_DROPPED_RX_0;

	ctrl_addr += port;

	ctrl_addr |= IND_ACC_TABLE(TABLE_MIB | TABLE_READ);

drivers/net/dsa/microchip/ksz8_reg.h

+3 −1
Original line number Diff line number Diff line
@@ -784,7 +784,9 @@ 
#define KSZ8795_MIB_TOTAL_TX_1		0x105



#define KSZ8863_MIB_PACKET_DROPPED_TX_0 0x100

#define KSZ8863_MIB_PACKET_DROPPED_RX_0 0x105

#define KSZ8863_MIB_PACKET_DROPPED_RX_0 0x103



#define KSZ8895_MIB_PACKET_DROPPED_RX_0 0x105



#define MIB_PACKET_DROPPED		0x0000FFFF