Commit 166fcf86 authored by Duoming Zhou's avatar Duoming Zhou Committed by Jakub Kicinski
Browse files

ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put() 



The object "ax25_dev" is managed by reference counting. Thus it should
not be directly released by kfree(), replace with ax25_dev_put().

Fixes: d01ffb9e ("ax25: add refcount in ax25_dev to avoid UAF bugs")
Suggested-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarDuoming Zhou <duoming@zju.edu.cn>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240530051733.11416-1-duoming@zju.edu.cn


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3c34fb0b

net/ax25/ax25_dev.c

+1 −1
Original line number Diff line number Diff line
@@ -196,7 +196,7 @@ void __exit ax25_dev_free(void) 
	list_for_each_entry_safe(s, n, &ax25_dev_list, list) {

		netdev_put(s->dev, &s->dev_tracker);

		list_del(&s->list);

		kfree(s);

		ax25_dev_put(s);

	}

	spin_unlock_bh(&ax25_dev_lock);

}