Commit 16724d6e authored by Luca Weiss's avatar Luca Weiss Committed by Greg Kroah-Hartman
Browse files

nvmem: qfprom: Mark core clk as optional 



On some platforms like sc7280 on non-ChromeOS devices the core clock
cannot be touched by Linux so we cannot provide it. Mark it as optional
as accessing qfprom for reading works without it but we still prohibit
writing if we cannot provide the clock.

Signed-off-by: default avatarLuca Weiss <luca.weiss@fairphone.com>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20231020105545.216052-2-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2399cde8

drivers/nvmem/qfprom.c

+3 −3
Original line number Diff line number Diff line
@@ -423,12 +423,12 @@ static int qfprom_probe(struct platform_device *pdev) 
		if (IS_ERR(priv->vcc))

			return PTR_ERR(priv->vcc);



		priv->secclk = devm_clk_get(dev, "core");

		priv->secclk = devm_clk_get_optional(dev, "core");

		if (IS_ERR(priv->secclk))

			return dev_err_probe(dev, PTR_ERR(priv->secclk), "Error getting clock\n");



		/* Only enable writing if we have SoC data. */

		if (priv->soc_data)

		/* Only enable writing if we have SoC data and a valid clock */

		if (priv->soc_data && priv->secclk)

			econfig.reg_write = qfprom_reg_write;

	}