Commit 1695c52a authored Sep 16, 2022 by Ciprian Regus Committed by Jonathan Cameron Sep 21, 2022

drivers: iio: adc: ltc2497: Rename the LTC2499 iio device



Set the iio device's name based on the chip used for the
LTC2499 only. The most common way for IIO clients to interact
with a device is to address it based on it's name. By using
the dev_name() function, the name will be set based on a
i2c_client's kobj name, which has the format i2c_instance-i2c_address
(1-0076 for example). This is not ideal, since it makes a
requirement for userspace to have knowledge about the hardware
connections of the device.

The name field is set to NULL for the LTC2497 and LTC2496, so
that the old name can kept as it is, since changing it will
result in an ABI breakage.

Signed-off-by: Ciprian Regus <ciprian.regus@analog.com>
Link: https://lore.kernel.org/r/20220916140922.2506248-6-ciprian.regus@analog.com


Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent 2187cfeb

drivers/iio/adc/ltc2496.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -89,6 +89,7 @@ static void ltc2496_remove(struct spi_device *spi)

		static const struct ltc2497_chip_info ltc2496_info = {
		.resolution = 16,
		.name = NULL,
		};

		static const struct of_device_id ltc2496_of_match[] = {

drivers/iio/adc/ltc2497-core.c

+9 −1

Original line number	Diff line number	Diff line
		@@ -169,7 +169,15 @@ int ltc2497core_probe(struct device dev, struct iio_dev indio_dev)
		struct ltc2497core_driverdata *ddata = iio_priv(indio_dev);
		int ret;

		/*
		* Keep using dev_name() for the iio_dev's name on some of the parts,
		* since updating it would result in a ABI breakage.
		*/
		if (ddata->chip_info->name)
		indio_dev->name = ddata->chip_info->name;
		else
		indio_dev->name = dev_name(dev);

		indio_dev->info = &ltc2497core_info;
		indio_dev->modes = INDIO_DIRECT_MODE;
		indio_dev->channels = ltc2497core_channel;

drivers/iio/adc/ltc2497.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -140,9 +140,11 @@ static int ltc2497_remove(struct i2c_client *client)
		static const struct ltc2497_chip_info ltc2497_info[] = {
		[TYPE_LTC2497] = {
		.resolution = 16,
		.name = NULL,
		},
		[TYPE_LTC2499] = {
		.resolution = 24,
		.name = "ltc2499",
		},
		};

drivers/iio/adc/ltc2497.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -6,6 +6,7 @@

		struct ltc2497_chip_info {
		u32 resolution;
		const char *name;
		};

		struct ltc2497core_driverdata {