Commit 16ae9580 authored by Ahmed Salem's avatar Ahmed Salem Committed by Rafael J. Wysocki
Browse files

ACPICA: acpidump: drop ACPI_NONSTRING attribute from file_name 

Partially revert commit 70662db7 ("ACPICA: Apply ACPI_NONSTRING in
more places") as I've yet again incorrectly applied the ACPI_NONSTRING
attribute where it is not needed.

A warning was initially reported by Collin Funk [1], and further review
by Jiri Slaby [2] highlighted another issue related to the same commit.

Drop the ACPI_NONSTRING attribute to fix the issue.

Fixes: 70662db7 ("ACPICA: Apply ACPI_NONSTRING in more places")
Link: https://lore.kernel.org/all/87ecvpcypw.fsf@gmail.com [1]
Link: https://lore.kernel.org/all/5c210121-c9b8-4458-b1ad-0da24732ac72@kernel.org [2]
Link: https://github.com/acpica/acpica/commit/a6ee09ca


Reported-by: default avatarCollin Funk <collin.funk1@gmail.com>
Signed-off-by: default avatarAhmed Salem <x0rw3ll@gmail.com>
Cc: 6.16+ <stable@vger.kernel.org> # 6.16+
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 4b020eff

tools/power/acpi/tools/acpidump/apfiles.c

+1 −1
Original line number Diff line number Diff line
@@ -103,7 +103,7 @@ int ap_open_output_file(char *pathname) 


int ap_write_to_binary_file(struct acpi_table_header *table, u32 instance)

{

	char filename[ACPI_NAMESEG_SIZE + 16] ACPI_NONSTRING;

	char filename[ACPI_NAMESEG_SIZE + 16];

	char instance_str[16];

	ACPI_FILE file;

	acpi_size actual;