Commit 16c8a3a6 authored by Sean Anderson's avatar Sean Anderson Committed by Jakub Kicinski
Browse files

net: macb: Fix offset error in gem_update_stats 



hw_stats now has only one variable for tx_octets/rx_octets, so we should
only increment p once, not twice. This would cause the statistics to be
reported under the wrong categories in `ethtool -S --all-groups` (which
uses hw_stats) but not `ethtool -S` (which uses ethtool_stats).

Signed-off-by: default avatarSean Anderson <sean.anderson@linux.dev>
Fixes: f6af690a ("net: cadence: macb: Report standard stats")
Link: https://patch.msgid.link/20250825172134.681861-1-sean.anderson@linux.dev


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 26c1f55f

drivers/net/ethernet/cadence/macb_main.c

+1 −1
Original line number Diff line number Diff line
@@ -3090,7 +3090,7 @@ static void gem_update_stats(struct macb *bp) 
			/* Add GEM_OCTTXH, GEM_OCTRXH */

			val = bp->macb_reg_readl(bp, offset + 4);

			bp->ethtool_stats[i] += ((u64)val) << 32;

			*(p++) += ((u64)val) << 32;

			*p += ((u64)val) << 32;

		}

	}