Commit 1705bbe7 authored by Dave Stevenson's avatar Dave Stevenson Committed by Rob Herring (Arm)
Browse files

dt-bindings: display: Fix brcm,bcm2835-hvs bindings for BCM2712 



Commit 6cfcbe54 ("dt-bindings: display: Add BCM2712 HVS bindings")
added the compatible string for BCM2712, but missed out that
the number of interrupts and clocks changed too.

The driver commit 7687a121 ("drm/vc4: hvs: Add support for BCM2712
HVS") also requires that both interrupts and clocks are named, so the
relevant -names properties are also added to "required" for BCM2712.

Update to validate clock, interrupts, and their names for the BCM2712
variant. (There should be no change in the binding requirements for
the other variants).

Fixes: 6cfcbe54 ("dt-bindings: display: Add BCM2712 HVS bindings")
Signed-off-by: default avatarDave Stevenson <dave.stevenson@raspberrypi.com>
Link: https://patch.msgid.link/20241220-dt-bcm2712-fixes-v5-2-cbbf13d2e97a@raspberrypi.com


Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
parent 3f7f6653

Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml

+74 −14
Original line number Diff line number Diff line
@@ -20,11 +20,20 @@ properties: 
    maxItems: 1



  interrupts:

    maxItems: 1

    minItems: 1

    maxItems: 3



  interrupt-names:

    minItems: 1

    maxItems: 3



  clocks:

    maxItems: 1

    description: Core Clock

    minItems: 1

    maxItems: 2



  clock-names:

    minItems: 1

    maxItems: 2



required:

  - compatible
@@ -33,17 +42,68 @@ required: 


additionalProperties: false



if:

allOf:

  - if:

      properties:

        compatible:

          contains:

        enum:

          - brcm,bcm2711-hvs

          - brcm,bcm2712-hvs

            const: brcm,bcm2711-hvs



    then:

      properties:

        clocks:

          items:

            - description: Core Clock

        interrupts:

          maxItems: 1

        clock-names: false

        interrupt-names: false



      required:

        - clocks



  - if:

      properties:

        compatible:

          contains:

            const: brcm,bcm2712-hvs



    then:

      properties:

        clocks:

          minItems: 2

          maxItems: 2

        clock-names:

          items:

            - const: core

            - const: disp

        interrupts:

          items:

            - description: Channel 0 End of frame

            - description: Channel 1 End of frame

            - description: Channel 2 End of frame

        interrupt-names:

          items:

            - const: ch0-eof

            - const: ch1-eof

            - const: ch2-eof

      required:

        - clocks

        - clock-names

        - interrupt-names



  - if:

      properties:

        compatible:

          contains:

            const: brcm,bcm2835-hvs



    then:

      properties:

        interrupts:

          maxItems: 1

        clock-names: false

        interrupt-names: false



examples:

  - |