Commit 170911bb authored by Michal Michalik's avatar Michal Michalik Committed by Tony Nguyen
Browse files

ice: Remove the FW shared parameters 



The only feature using the Firmware (FW) shared parameters was the PTP
clock ID. Since this ID is now shared using auxiliary buss - remove the
FW shared parameters from the code.

Signed-off-by: default avatarMichal Michalik <michal.michalik@intel.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent fcd2c1e3

drivers/net/ethernet/intel/ice/ice_adminq_cmd.h

+0 −5
Original line number Diff line number Diff line
@@ -2358,11 +2358,6 @@ struct ice_aqc_driver_shared_params { 
	__le32 addr_low;

};



enum ice_aqc_driver_params {

	/* Add new parameters above */

	ICE_AQC_DRIVER_PARAM_MAX = 16,

};



/* Lan Queue Overflow Event (direct, 0x1001) */

struct ice_aqc_event_lan_overflow {

	__le32 prtdcb_ruptq;

drivers/net/ethernet/intel/ice/ice_common.c

+0 −75
Original line number Diff line number Diff line
@@ -5720,81 +5720,6 @@ ice_aq_write_i2c(struct ice_hw *hw, struct ice_aqc_link_topo_addr topo_addr, 
	return ice_aq_send_cmd(hw, &desc, NULL, 0, cd);

}



/**

 * ice_aq_set_driver_param - Set driver parameter to share via firmware

 * @hw: pointer to the HW struct

 * @idx: parameter index to set

 * @value: the value to set the parameter to

 * @cd: pointer to command details structure or NULL

 *

 * Set the value of one of the software defined parameters. All PFs connected

 * to this device can read the value using ice_aq_get_driver_param.

 *

 * Note that firmware provides no synchronization or locking, and will not

 * save the parameter value during a device reset. It is expected that

 * a single PF will write the parameter value, while all other PFs will only

 * read it.

 */

int

ice_aq_set_driver_param(struct ice_hw *hw, enum ice_aqc_driver_params idx,

			u32 value, struct ice_sq_cd *cd)

{

	struct ice_aqc_driver_shared_params *cmd;

	struct ice_aq_desc desc;



	if (idx >= ICE_AQC_DRIVER_PARAM_MAX)

		return -EIO;



	cmd = &desc.params.drv_shared_params;



	ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_driver_shared_params);



	cmd->set_or_get_op = ICE_AQC_DRIVER_PARAM_SET;

	cmd->param_indx = idx;

	cmd->param_val = cpu_to_le32(value);



	return ice_aq_send_cmd(hw, &desc, NULL, 0, cd);

}



/**

 * ice_aq_get_driver_param - Get driver parameter shared via firmware

 * @hw: pointer to the HW struct

 * @idx: parameter index to set

 * @value: storage to return the shared parameter

 * @cd: pointer to command details structure or NULL

 *

 * Get the value of one of the software defined parameters.

 *

 * Note that firmware provides no synchronization or locking. It is expected

 * that only a single PF will write a given parameter.

 */

int

ice_aq_get_driver_param(struct ice_hw *hw, enum ice_aqc_driver_params idx,

			u32 *value, struct ice_sq_cd *cd)

{

	struct ice_aqc_driver_shared_params *cmd;

	struct ice_aq_desc desc;

	int status;



	if (idx >= ICE_AQC_DRIVER_PARAM_MAX)

		return -EIO;



	cmd = &desc.params.drv_shared_params;



	ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_driver_shared_params);



	cmd->set_or_get_op = ICE_AQC_DRIVER_PARAM_GET;

	cmd->param_indx = idx;



	status = ice_aq_send_cmd(hw, &desc, NULL, 0, cd);

	if (status)

		return status;



	*value = le32_to_cpu(cmd->param_val);



	return 0;

}



/**

 * ice_aq_set_gpio

 * @hw: pointer to the hw struct

drivers/net/ethernet/intel/ice/ice_common.h

+0 −6
Original line number Diff line number Diff line
@@ -253,12 +253,6 @@ int 
ice_sched_query_elem(struct ice_hw *hw, u32 node_teid,

		     struct ice_aqc_txsched_elem_data *buf);

int

ice_aq_set_driver_param(struct ice_hw *hw, enum ice_aqc_driver_params idx,

			u32 value, struct ice_sq_cd *cd);

int

ice_aq_get_driver_param(struct ice_hw *hw, enum ice_aqc_driver_params idx,

			u32 *value, struct ice_sq_cd *cd);

int

ice_aq_set_gpio(struct ice_hw *hw, u16 gpio_ctrl_handle, u8 pin_idx, bool value,

		struct ice_sq_cd *cd);

int