Commit 174e7d0f authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

Revert "usb: typec: ucsi: Enable debugfs for message_out data structure" 



This reverts commit 775fae52.

The new buffer management code that this relies on is broken so revert
for now.

It also looks like the error handling needs some more thought as the
message out size is not reset on errors.

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://patch.msgid.link/20251222152204.2846-3-johan@kernel.org
parent 784b756d

drivers/usb/typec/ucsi/debugfs.c

+0 −26
Original line number Diff line number Diff line
@@ -110,30 +110,6 @@ static int ucsi_vbus_volt_show(struct seq_file *m, void *v) 
}

DEFINE_SHOW_ATTRIBUTE(ucsi_vbus_volt);



static ssize_t ucsi_message_out_write(struct file *file,

				      const char __user *data, size_t count, loff_t *ppos)

{

	struct ucsi *ucsi = file->private_data;

	int ret;



	char *buf __free(kfree) = memdup_user_nul(data, count);

	if (IS_ERR(buf))

		return PTR_ERR(buf);



	ucsi->message_out_size = min(count / 2, UCSI_MAX_MESSAGE_OUT_LENGTH);

	ret = hex2bin(ucsi->message_out, buf, ucsi->message_out_size);

	if (ret)

		return ret;



	return count;

}



static const struct file_operations ucsi_message_out_fops = {

	.open = simple_open,

	.write = ucsi_message_out_write,

	.llseek = generic_file_llseek,

};



void ucsi_debugfs_register(struct ucsi *ucsi)

{

	ucsi->debugfs = kzalloc(sizeof(*ucsi->debugfs), GFP_KERNEL);
@@ -146,8 +122,6 @@ void ucsi_debugfs_register(struct ucsi *ucsi) 
	debugfs_create_file("peak_current", 0400, ucsi->debugfs->dentry, ucsi, &ucsi_peak_curr_fops);

	debugfs_create_file("avg_current", 0400, ucsi->debugfs->dentry, ucsi, &ucsi_avg_curr_fops);

	debugfs_create_file("vbus_voltage", 0400, ucsi->debugfs->dentry, ucsi, &ucsi_vbus_volt_fops);

	debugfs_create_file("message_out", 0200, ucsi->debugfs->dentry, ucsi,

			    &ucsi_message_out_fops);

}



void ucsi_debugfs_unregister(struct ucsi *ucsi)