Commit 1769f90e authored by Carlos Llamas's avatar Carlos Llamas Committed by Greg Kroah-Hartman
Browse files

binder: fix BR_FROZEN_REPLY error log 



The error logging for failed transactions is misleading as it always
reports "dead process or thread" even when the target is actually
frozen. Additionally, the pid and tid are reversed which can further
confuse debugging efforts. Fix both issues.

Cc: stable@kernel.org
Cc: Steven Moreland <smoreland@google.com>
Fixes: a15dac8b ("binder: additional transaction error logs")
Signed-off-by: default avatarCarlos Llamas <cmllamas@google.com>
Reviewed-by: default avatarAlice Ryhl <aliceryhl@google.com>
Link: https://patch.msgid.link/20260123175702.2154348-1-cmllamas@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d0472481

drivers/android/binder.c

+3 −2
Original line number Diff line number Diff line
@@ -3824,8 +3824,9 @@ static void binder_transaction(struct binder_proc *proc, 
	return;



err_dead_proc_or_thread:

	binder_txn_error("%d:%d dead process or thread\n",

		thread->pid, proc->pid);

	binder_txn_error("%d:%d %s process or thread\n",

			 proc->pid, thread->pid,

			 return_error == BR_FROZEN_REPLY ? "frozen" : "dead");

	return_error_line = __LINE__;

	binder_dequeue_work(proc, tcomplete);

err_translate_failed: