Commit 178e00f3 authored by Sherry Sun's avatar Sherry Sun Committed by Greg Kroah-Hartman
Browse files

tty: serial: fsl_lpuart: fix crash in lpuart_uport_is_active 



For serdev framework, tty->dev is a NULL pointer, lpuart_uport_is_active
calling device_may_wakeup() may cause kernel NULL pointer crash, so here
add the NULL pointer check before using it.

Fixes: 4f5cb8c5 ("tty: serial: fsl_lpuart: enable wakeup source for lpuart")
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarSherry Sun <sherry.sun@nxp.com>
Link: https://lore.kernel.org/r/20230323110923.24581-1-sherry.sun@nxp.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9425914f

drivers/tty/serial/fsl_lpuart.c

+1 −1
Original line number Diff line number Diff line
@@ -2948,7 +2948,7 @@ static bool lpuart_uport_is_active(struct lpuart_port *sport) 
	tty = tty_port_tty_get(port);

	if (tty) {

		tty_dev = tty->dev;

		may_wake = device_may_wakeup(tty_dev);

		may_wake = tty_dev && device_may_wakeup(tty_dev);

		tty_kref_put(tty);

	}