Commit 17e94b25 authored by SEO HOYOUNG's avatar SEO HOYOUNG Committed by Martin K. Petersen
Browse files

scsi: ufs: core: Remove the ufshcd_release() in ufshcd_err_handling_prepare() 



If ufshcd_err_handler() is called in a suspend/resume situation,
ufs_release() can be called twice and active_reqs end up going negative.
This is because ufshcd_err_handling_prepare() and
ufshcd_err_handling_unprepare() both call ufshcd_release().

Remove superfluous call to ufshcd_release().

Signed-off-by: default avatarSEO HOYOUNG <hy50.seo@samsung.com>
Link: https://lore.kernel.org/r/20240122083324.11797-1-hy50.seo@samsung.com


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Reviewed-by: default avatarCan Guo <quic_cang@quicinc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent b513d30d

drivers/ufs/core/ufshcd.c

+0 −1
Original line number Diff line number Diff line
@@ -6354,7 +6354,6 @@ static void ufshcd_err_handling_prepare(struct ufs_hba *hba) 
		ufshcd_hold(hba);

		if (!ufshcd_is_clkgating_allowed(hba))

			ufshcd_setup_clocks(hba, true);

		ufshcd_release(hba);

		pm_op = hba->is_sys_suspended ? UFS_SYSTEM_PM : UFS_RUNTIME_PM;

		ufshcd_vops_resume(hba, pm_op);

	} else {