Commit 182422c7 authored by Huisong Li's avatar Huisong Li Committed by Rafael J. Wysocki
Browse files

ACPI: processor: idle: Convert acpi_processor_setup_cpuidle_states() to void 



Since all callers of acpi_processor_setup_cpuidle_states() ignore its
return value and it simply passes the acpi_processor_setup_lpi_states()
return value to its callers, convert both of these functions to void.

No intentional functional impact.

Signed-off-by: default avatarHuisong Li <lihuisong@huawei.com>
[ rjw: Subject and changelog edits ]
Link: https://patch.msgid.link/20260120112258.1595164-2-lihuisong@huawei.com


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 9be35201

drivers/acpi/processor_idle.c

+8 −9
Original line number Diff line number Diff line
@@ -1180,7 +1180,7 @@ static int acpi_idle_lpi_enter(struct cpuidle_device *dev, 
	return -EINVAL;

}



static int acpi_processor_setup_lpi_states(struct acpi_processor *pr)

static void acpi_processor_setup_lpi_states(struct acpi_processor *pr)

{

	int i;

	struct acpi_lpi_state *lpi;
@@ -1188,7 +1188,7 @@ static int acpi_processor_setup_lpi_states(struct acpi_processor *pr) 
	struct cpuidle_driver *drv = &acpi_idle_driver;



	if (!pr->flags.has_lpi)

		return -EOPNOTSUPP;

		return;



	for (i = 0; i < pr->power.count && i < CPUIDLE_STATE_MAX; i++) {

		lpi = &pr->power.lpi_states[i];
@@ -1206,8 +1206,6 @@ static int acpi_processor_setup_lpi_states(struct acpi_processor *pr) 
	}



	drv->state_count = i;



	return 0;

}



/**
@@ -1216,13 +1214,13 @@ static int acpi_processor_setup_lpi_states(struct acpi_processor *pr) 
 *

 * @pr: the ACPI processor

 */

static int acpi_processor_setup_cpuidle_states(struct acpi_processor *pr)

static void acpi_processor_setup_cpuidle_states(struct acpi_processor *pr)

{

	int i;

	struct cpuidle_driver *drv = &acpi_idle_driver;



	if (!pr->flags.power_setup_done || !pr->flags.power)

		return -EINVAL;

		return;



	drv->safe_state_index = -1;

	for (i = ACPI_IDLE_STATE_START; i < CPUIDLE_STATE_MAX; i++) {
@@ -1230,11 +1228,12 @@ static int acpi_processor_setup_cpuidle_states(struct acpi_processor *pr) 
		drv->states[i].desc[0] = '\0';

	}



	if (pr->flags.has_lpi)

		return acpi_processor_setup_lpi_states(pr);

	if (pr->flags.has_lpi) {

		acpi_processor_setup_lpi_states(pr);

		return;

	}



	acpi_processor_setup_cstates(pr);

	return 0;

}



/**