Commit 183b6413 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

thermal: netlink: Use for_each_trip() in thermal_genl_cmd_tz_get_trip() 



Make thermal_genl_cmd_tz_get_trip() use for_each_trip() instead of an open-
coded loop over trip indices.

No intentional functional impact.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: default avatarLukasz Luba <lukasz.luba@arm.com>
parent 2e3e7dad

drivers/thermal/thermal_netlink.c

+8 −12
Original line number Diff line number Diff line
@@ -450,10 +450,10 @@ static int thermal_genl_cmd_tz_get_id(struct param *p) 
static int thermal_genl_cmd_tz_get_trip(struct param *p)

{

	struct sk_buff *msg = p->msg;

	const struct thermal_trip *trip;

	struct thermal_zone_device *tz;

	struct nlattr *start_trip;

	struct thermal_trip trip;

	int ret, i, id;

	int id;



	if (!p->attrs[THERMAL_GENL_ATTR_TZ_ID])

		return -EINVAL;
@@ -470,16 +470,12 @@ static int thermal_genl_cmd_tz_get_trip(struct param *p) 


	mutex_lock(&tz->lock);



	for (i = 0; i < tz->num_trips; i++) {



		ret = __thermal_zone_get_trip(tz, i, &trip);

		if (ret)

			goto out_cancel_nest;



		if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, i) ||

		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_TYPE, trip.type) ||

		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_TEMP, trip.temperature) ||

		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_HYST, trip.hysteresis))

	for_each_trip(tz, trip) {

		if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_ID,

				thermal_zone_trip_id(tz, trip)) ||

		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_TYPE, trip->type) ||

		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_TEMP, trip->temperature) ||

		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_HYST, trip->hysteresis))

			goto out_cancel_nest;

	}