Commit 18429e6e authored by Ignat Korchagin's avatar Ignat Korchagin Committed by Jakub Kicinski
Browse files

Revert "net: do not leave a dangling sk pointer, when socket creation fails" 



This reverts commit 6cd4a78d.

inet/inet6->create() implementations have been fixed to explicitly NULL the
allocated sk object on error.

A warning was put in place to make sure any future changes will not leave
a dangling pointer in pf->create() implementations.

So this code is now redundant.

Suggested-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarIgnat Korchagin <ignat@cloudflare.com>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20241014153808.51894-10-ignat@cloudflare.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 48156296

net/core/sock.c

+0 −3
Original line number Diff line number Diff line
@@ -3827,9 +3827,6 @@ void sk_common_release(struct sock *sk) 


	sk->sk_prot->unhash(sk);



	if (sk->sk_socket)

		sk->sk_socket->sk = NULL;



	/*

	 * In this point socket cannot receive new packets, but it is possible

	 * that some packets are in flight because some CPU runs receiver and