Commit 186e8f2b authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

usb: host: max3421-hcd: Fix error pointer dereference in probe cleanup 



The kthread_run() function returns error pointers so the
max3421_hcd->spi_thread pointer can be either error pointers or NULL.
Check for both before dereferencing it.

Fixes: 05dfa5c9 ("usb: host: max3421-hcd: fix "spi_rd8" uses dynamic stack allocation warning")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/aJTMVAPtRe5H6jug@stanley.mountain


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent aeb01692

drivers/usb/host/max3421-hcd.c

+1 −1
Original line number Diff line number Diff line
@@ -1916,7 +1916,7 @@ max3421_probe(struct spi_device *spi) 
	if (hcd) {

		kfree(max3421_hcd->tx);

		kfree(max3421_hcd->rx);

		if (max3421_hcd->spi_thread)

		if (!IS_ERR_OR_NULL(max3421_hcd->spi_thread))

			kthread_stop(max3421_hcd->spi_thread);

		usb_put_hcd(hcd);

	}