Commit 1882e769 authored by Shen Lichuan's avatar Shen Lichuan Committed by Bartosz Golaszewski
Browse files

gpio: stmpe: Simplify with dev_err_probe() 



Use dev_err_probe() to simplify the error path and unify a message
template.

Using this helper is totally fine even if err is known to never
be -EPROBE_DEFER.

The benefit compared to a normal dev_err() is the standardized format
of the error code, it being emitted symbolically and the fact that
the error code is returned which allows more compact error paths.

Signed-off-by: default avatarShen Lichuan <shenlichuan@vivo.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240829131051.43200-1-shenlichuan@vivo.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent c4a315ea

drivers/gpio/gpio-stmpe.c

+3 −4
Original line number Diff line number Diff line
@@ -513,10 +513,9 @@ static int stmpe_gpio_probe(struct platform_device *pdev) 
		ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,

				stmpe_gpio_irq, IRQF_ONESHOT,

				"stmpe-gpio", stmpe_gpio);

		if (ret) {

			dev_err(&pdev->dev, "unable to get irq: %d\n", ret);

			return ret;

		}

		if (ret)

			return dev_err_probe(&pdev->dev, ret,

					     "unable to get irq");



		girq = &stmpe_gpio->chip.irq;

		gpio_irq_chip_set_chip(girq, &stmpe_gpio_irq_chip);