Unverified Commit 1889dd20 authored by Anurag Dutta's avatar Anurag Dutta Committed by Mark Brown
Browse files

spi: cadence-quadspi: Fix clock disable on probe failure path 



When cqspi_request_mmap_dma() returns -EPROBE_DEFER after runtime PM
is enabled, the error path calls clk_disable_unprepare() on an already
disabled clock, causing an imbalance.

Use pm_runtime_get_sync() to increment the usage counter and resume the
device. This prevents runtime_suspend() from being invoked and causing
a double clock disable.

Fixes: 14062341 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")
Signed-off-by: default avatarAnurag Dutta <a-dutta@ti.com>
Tested-by: default avatarNishanth Menon <nm@ti.com>
Link: https://patch.msgid.link/20251212072312.2711806-3-a-dutta@ti.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b1f54d71

drivers/spi/spi-cadence-quadspi.c

+3 −1
Original line number Diff line number Diff line
@@ -2026,6 +2026,8 @@ static int cqspi_probe(struct platform_device *pdev) 
probe_reset_failed:

	if (cqspi->is_jh7110)

		cqspi_jh7110_disable_clk(pdev, cqspi);



	if (pm_runtime_get_sync(&pdev->dev) >= 0)

		clk_disable_unprepare(cqspi->clk);

probe_clk_failed:

	return ret;