Commit 188a8646 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/sunxvr500: Initialize fb_ops to fbdev I/O-memory helpers 



Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. Set the read/write,
draw and mmap callbacks to the correct implementation and avoid
implicit defaults. Also select the necessary I/O helpers in Kconfig.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default implementation to be invoked; hence requiring the I/O
helpers to be built in any case. Setting all callbacks in all
drivers explicitly will allow to make the I/O helpers optional.
This benefits systems that do not use these functions.

No functional changes.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-40-tzimmermann@suse.de
parent 6cdc804e

drivers/video/fbdev/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -596,6 +596,7 @@ config FB_XVR500 
	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT

	select FB_IOMEM_FOPS

	select VIDEO_NOMODESET

	help

	  This is the framebuffer device for the Sun XVR-500 and similar

drivers/video/fbdev/sunxvr500.c

+2 −0
Original line number Diff line number Diff line
@@ -189,10 +189,12 @@ static void e3d_copyarea(struct fb_info *info, const struct fb_copyarea *area) 


static const struct fb_ops e3d_ops = {

	.owner			= THIS_MODULE,

	__FB_DEFAULT_IOMEM_OPS_RDWR,

	.fb_setcolreg		= e3d_setcolreg,

	.fb_fillrect		= e3d_fillrect,

	.fb_copyarea		= e3d_copyarea,

	.fb_imageblit		= e3d_imageblit,

	__FB_DEFAULT_IOMEM_OPS_MMAP,

};



static int e3d_set_fbinfo(struct e3d_info *ep)