Commit 1918f983 authored by Suchit Karunakaran's avatar Suchit Karunakaran Committed by Masahiro Yamada
Browse files

kconfig: lxdialog: replace strcpy with snprintf in print_autowrap 



strcpy() does not perform bounds checking and can lead to buffer overflows
if the source string exceeds the destination buffer size. In
print_autowrap(), replace strcpy() with snprintf() to safely copy the
prompt string into the fixed-size tempstr buffer.

Signed-off-by: default avatarSuchit Karunakaran <suchitkarunakaran@gmail.com>
Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
parent eb549e19

scripts/kconfig/lxdialog/util.c

+1 −2
Original line number Diff line number Diff line
@@ -345,8 +345,7 @@ void print_autowrap(WINDOW * win, const char *prompt, int width, int y, int x) 
	int prompt_len, room, wlen;

	char tempstr[MAX_LEN + 1], *word, *sp, *sp2, *newline_separator = 0;



	strcpy(tempstr, prompt);



	snprintf(tempstr, sizeof(tempstr), "%s", prompt);

	prompt_len = strlen(tempstr);



	if (prompt_len <= width - x * 2) {	/* If prompt is short */