Commit 192e3aa1 authored by Paul Chaignon's avatar Paul Chaignon Committed by Alexei Starovoitov
Browse files

selftests/bpf: Negative test case for tail call map 



This patch adds a negative test case for the following verifier error.

    expected prog array map for tail call

Acked-by: default avatarYonghong Song <yonghong.song@linux.dev>
Signed-off-by: default avatarPaul Chaignon <paul.chaignon@gmail.com>
Acked-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/r/aGu0i1X_jII-3aFa@mail.gmail.com


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent df4b1eeb

tools/testing/selftests/bpf/prog_tests/verifier.c

+2 −0
Original line number Diff line number Diff line
@@ -85,6 +85,7 @@ 
#include "verifier_store_release.skel.h"

#include "verifier_subprog_precision.skel.h"

#include "verifier_subreg.skel.h"

#include "verifier_tailcall.skel.h"

#include "verifier_tailcall_jit.skel.h"

#include "verifier_typedef.skel.h"

#include "verifier_uninit.skel.h"
@@ -219,6 +220,7 @@ void test_verifier_stack_ptr(void) { RUN(verifier_stack_ptr); } 
void test_verifier_store_release(void)        { RUN(verifier_store_release); }

void test_verifier_subprog_precision(void)    { RUN(verifier_subprog_precision); }

void test_verifier_subreg(void)               { RUN(verifier_subreg); }

void test_verifier_tailcall(void)             { RUN(verifier_tailcall); }

void test_verifier_tailcall_jit(void)         { RUN(verifier_tailcall_jit); }

void test_verifier_typedef(void)              { RUN(verifier_typedef); }

void test_verifier_uninit(void)               { RUN(verifier_uninit); }

tools/testing/selftests/bpf/progs/verifier_tailcall.c

0 → 100644
+31 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0



#include <linux/bpf.h>

#include <bpf/bpf_helpers.h>

#include "bpf_misc.h"



struct {

	__uint(type, BPF_MAP_TYPE_ARRAY);

	__uint(max_entries, 1);

	__type(key, __u32);

	__type(value, __u32);

} map_array SEC(".maps");



SEC("socket")

__description("invalid map type for tail call")

__failure __msg("expected prog array map for tail call")

__failure_unpriv

__naked void invalid_map_for_tail_call(void)

{

	asm volatile ("			\

	r2 = %[map_array] ll;	\

	r3 = 0;				\

	call %[bpf_tail_call];		\

	exit;				\

"	:

	: __imm(bpf_tail_call),

	  __imm_addr(map_array)

	: __clobber_all);

}



char _license[] SEC("license") = "GPL";