Commit 1932db20 authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Alexandre Belloni
Browse files

rtc: amlogic-a4: Remove IRQF_ONESHOT 



Passing IRQF_ONESHOT ensures that the interrupt source is masked until
the secondary (threaded) handler is done. If only a primary handler is
used then the flag makes no sense because the interrupt can not fire
(again) while its handler is running.
The flag also disallows force-threading of the primary handler and the
irq-core will warn about this.

Remove IRQF_ONESHOT from irqflags.

Fixes: c89ac918 ("rtc: support for the Amlogic on-chip RTC")
Reviewed-by: default avatarXianwei Zhao <xianwei.zhao@amlogic.com>
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://patch.msgid.link/20260128095540.863589-13-bigeasy@linutronix.de


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent a380a02e

drivers/rtc/rtc-amlogic-a4.c

+1 −1
Original line number Diff line number Diff line
@@ -369,7 +369,7 @@ static int aml_rtc_probe(struct platform_device *pdev) 
		return PTR_ERR(rtc->rtc_dev);



	ret = devm_request_irq(dev, rtc->irq, aml_rtc_handler,

			       IRQF_ONESHOT, "aml-rtc alarm", rtc);

			       0, "aml-rtc alarm", rtc);

	if (ret) {

		dev_err_probe(dev, ret, "IRQ%d request failed, ret = %d\n",

			      rtc->irq, ret);