Commit 193879e2 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

genirq/manage: Rework irq_set_irqchip_state() 



Use the new guards to get and lock the interrupt descriptor and tidy up the
code.

No functional change.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065422.670808288@linutronix.de
parent 782249a9

kernel/irq/manage.c

+15 −28
Original line number Diff line number Diff line
@@ -2703,39 +2703,26 @@ EXPORT_SYMBOL_GPL(irq_get_irqchip_state); 
 */

int irq_set_irqchip_state(unsigned int irq, enum irqchip_irq_state which, bool val)

{

	struct irq_desc *desc;

	struct irq_data *data;

	scoped_irqdesc_get_and_buslock(irq, 0) {

		struct irq_data *data = irq_desc_get_irq_data(scoped_irqdesc);

		struct irq_chip *chip;

	unsigned long flags;

	int err = -EINVAL;



	desc = irq_get_desc_buslock(irq, &flags, 0);

	if (!desc)

		return err;



	data = irq_desc_get_irq_data(desc);



		do {

			chip = irq_data_get_irq_chip(data);

		if (WARN_ON_ONCE(!chip)) {

			err = -ENODEV;

			goto out_unlock;

		}



			if (WARN_ON_ONCE(!chip))

				return -ENODEV;



			if (chip->irq_set_irqchip_state)

				break;

#ifdef CONFIG_IRQ_DOMAIN_HIERARCHY

		data = data->parent_data;

#else

		data = NULL;

#endif



			data = irqd_get_parent_data(data);

		} while (data);



		if (data)

		err = chip->irq_set_irqchip_state(data, which, val);



out_unlock:

	irq_put_desc_busunlock(desc, flags);

	return err;

			return chip->irq_set_irqchip_state(data, which, val);

	}

	return -EINVAL;

}

EXPORT_SYMBOL_GPL(irq_set_irqchip_state);