Unverified Commit 194f8692 authored by Zihao Wang's avatar Zihao Wang Committed by Mark Brown
Browse files

ASoC: tegra20_ac97: Add missing unwind goto in tegra20_ac97_platform_probe() 



Smatch Warns:
	sound/soc/tegra/tegra20_ac97.c:321 tegra20_ac97_platform_probe()
	warn: missing unwind goto?

The goto will set the "soc_ac97_ops" and "soc_ac97_bus" operations to
NULL.  But they are already NULL at this point so it is a no-op.
However, just for consistency, change the direct return to a goto.  No
functional change.

Signed-off-by: default avatarZihao Wang <u202012060@hust.edu.cn>
Reviewed-by: default avatarDan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/20230404084622.1202-1-u202012060@hust.edu.cn


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 3af24372

sound/soc/tegra/tegra20_ac97.c

+2 −1
Original line number Diff line number Diff line
@@ -318,7 +318,8 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev) 
	ac97->reset = devm_reset_control_get_exclusive(&pdev->dev, "ac97");

	if (IS_ERR(ac97->reset)) {

		dev_err(&pdev->dev, "Can't retrieve ac97 reset\n");

		return PTR_ERR(ac97->reset);

		ret = PTR_ERR(ac97->reset);

		goto err;

	}



	ac97->clk_ac97 = devm_clk_get(&pdev->dev, NULL);