Commit 195f88c5 authored by Breno Leitao's avatar Breno Leitao Committed by Jakub Kicinski
Browse files

vxlan: Remove generic .ndo_get_stats64 



Commit 3e2f544d ("net: get stats64 if device if driver is
configured") moved the callback to dev_get_tstats64() to net core, so,
unless the driver is doing some custom stats collection, it does not
need to set .ndo_get_stats64.

Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
function pointer.

Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Reviewed-by: default avatarSubbaraya Sundeep <sbhatta@marvell.com>
Link: https://lore.kernel.org/r/20240311112437.3813987-2-leitao@debian.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e28c5efc

drivers/net/vxlan/vxlan_core.c

+0 −2
Original line number Diff line number Diff line
@@ -3214,7 +3214,6 @@ static const struct net_device_ops vxlan_netdev_ether_ops = { 
	.ndo_open		= vxlan_open,

	.ndo_stop		= vxlan_stop,

	.ndo_start_xmit		= vxlan_xmit,

	.ndo_get_stats64	= dev_get_tstats64,

	.ndo_set_rx_mode	= vxlan_set_multicast_list,

	.ndo_change_mtu		= vxlan_change_mtu,

	.ndo_validate_addr	= eth_validate_addr,
@@ -3238,7 +3237,6 @@ static const struct net_device_ops vxlan_netdev_raw_ops = { 
	.ndo_open		= vxlan_open,

	.ndo_stop		= vxlan_stop,

	.ndo_start_xmit		= vxlan_xmit,

	.ndo_get_stats64	= dev_get_tstats64,

	.ndo_change_mtu		= vxlan_change_mtu,

	.ndo_fill_metadata_dst	= vxlan_fill_metadata_dst,

};