Unverified Commit 19c70b46 authored by Wolfram Sang's avatar Wolfram Sang Committed by Mark Brown
Browse files

ASoC: codecs: wm8994: use 'time_left' variable with wait_for_completion_timeout() 



There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

	timeout = wait_for_completion_timeout(...)
	if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240430115438.29134-4-wsa+renesas@sang-engineering.com


Reviewed-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0800660d

sound/soc/codecs/wm8994.c

+4 −4
Original line number Diff line number Diff line
@@ -2210,7 +2210,7 @@ static int _wm8994_set_fll(struct snd_soc_component *component, int id, int src, 
	int reg_offset, ret;

	struct fll_div fll;

	u16 reg, clk1, aif_reg, aif_src;

	unsigned long timeout;

	unsigned long time_left;

	bool was_enabled;

	struct clk *mclk;
@@ -2403,9 +2403,9 @@ static int _wm8994_set_fll(struct snd_soc_component *component, int id, int src, 
				    WM8994_FLL1_FRAC, reg);



		if (wm8994->fll_locked_irq) {

			timeout = wait_for_completion_timeout(&wm8994->fll_locked[id],

			time_left = wait_for_completion_timeout(&wm8994->fll_locked[id],

								msecs_to_jiffies(10));

			if (timeout == 0)

			if (time_left == 0)

				dev_warn(component->dev,

					 "Timed out waiting for FLL lock\n");

		} else {