Commit 19c839a9 authored by Sébastien Szymanski's avatar Sébastien Szymanski Committed by Andy Shevchenko
Browse files

gpiolib: acpi: initialize acpi_gpio_info struct 

Since commit 7c010d46 ("gpiolib: acpi: Make sure we fill struct
acpi_gpio_info"), uninitialized acpi_gpio_info struct are passed to
__acpi_find_gpio() and later in the call stack info->quirks is used in
acpi_populate_gpio_lookup. This breaks the i2c_hid_cpi driver:

[   58.122916] i2c_hid_acpi i2c-UNIW0001:00: HID over i2c has not been provided an Int IRQ
[   58.123097] i2c_hid_acpi i2c-UNIW0001:00: probe with driver i2c_hid_acpi failed with error -22

Fix this by initializing the acpi_gpio_info pass to __acpi_find_gpio()

Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220388


Fixes: 7c010d46 ("gpiolib: acpi: Make sure we fill struct acpi_gpio_info")
Signed-off-by: default avatarSébastien Szymanski <sebastien.szymanski@armadeus.com>
Tested-by: default avatarHans de Goede <hansg@kernel.org>
Reviewed-by: default avatarHans de Goede <hansg@kernel.org>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Tested-By: default avatarCalvin Owens <calvin@wbinvd.org>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 3712ce9f

drivers/gpio/gpiolib-acpi-core.c

+2 −2
Original line number Diff line number Diff line
@@ -942,7 +942,7 @@ struct gpio_desc *acpi_find_gpio(struct fwnode_handle *fwnode, 
{

	struct acpi_device *adev = to_acpi_device_node(fwnode);

	bool can_fallback = acpi_can_fallback_to_crs(adev, con_id);

	struct acpi_gpio_info info;

	struct acpi_gpio_info info = {};

	struct gpio_desc *desc;

	int ret;
@@ -999,7 +999,7 @@ int acpi_dev_gpio_irq_wake_get_by(struct acpi_device *adev, const char *con_id, 
	int ret;



	for (i = 0, idx = 0; idx <= index; i++) {

		struct acpi_gpio_info info;

		struct acpi_gpio_info info = {};

		struct gpio_desc *desc;



		/* Ignore -EPROBE_DEFER, it only matters if idx matches */