Commit 19f4422d authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf test: Directory file descriptor leak 



Add missed close when iterating over the script directories.

Fixes: f3295f5b ("perf tests: Use scandirat for shell script finding")
Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>
Link: https://lore.kernel.org/r/20250614004108.1650988-1-irogers@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent ebec62bc

tools/perf/tests/tests-scripts.c

+1 −0
Original line number Diff line number Diff line
@@ -260,6 +260,7 @@ static void append_scripts_in_dir(int dir_fd, 
			continue; /* Skip scripts that have a separate driver. */

		fd = openat(dir_fd, ent->d_name, O_PATH);

		append_scripts_in_dir(fd, result, result_sz);

		close(fd);

	}

	for (i = 0; i < n_dirs; i++) /* Clean up */

		zfree(&entlist[i]);