Commit 19fa6e49 authored by Markus Elfring's avatar Markus Elfring Committed by Carlos Maiolino
Browse files

xfs: Improve error handling in xfs_mru_cache_create() 



Simplify error handling in this function implementation.

* Delete unnecessary pointer checks and variable assignments.

* Omit a redundant function call.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarCarlos Maiolino <cem@kernel.org>
parent 0989dfa6

fs/xfs/xfs_mru_cache.c

+4 −11
Original line number Diff line number Diff line
@@ -320,7 +320,7 @@ xfs_mru_cache_create( 
	xfs_mru_cache_free_func_t free_func)

{

	struct xfs_mru_cache	*mru = NULL;

	int			err = 0, grp;

	int			grp;

	unsigned int		grp_time;



	if (mrup)
@@ -341,8 +341,8 @@ xfs_mru_cache_create( 
	mru->lists = kzalloc(mru->grp_count * sizeof(*mru->lists),

				GFP_KERNEL | __GFP_NOFAIL);

	if (!mru->lists) {

		err = -ENOMEM;

		goto exit;

		kfree(mru);

		return -ENOMEM;

	}



	for (grp = 0; grp < mru->grp_count; grp++)
@@ -361,14 +361,7 @@ xfs_mru_cache_create( 
	mru->free_func = free_func;

	mru->data = data;

	*mrup = mru;



exit:

	if (err && mru && mru->lists)

		kfree(mru->lists);

	if (err && mru)

		kfree(mru);



	return err;

	return 0;

}



/*