Commit 1a00a393 authored by Edward Adam Davis's avatar Edward Adam Davis Committed by Theodore Ts'o
Browse files

ext4: no need to continue when the number of entries is 1 



Fixes: ac27a0ec ("[PATCH] ext4: initial copy of files from ext3")
Reported-by: default avatar <syzbot+ae688d469e36fb5138d0@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=ae688d469e36fb5138d0


Signed-off-by: default avatarEdward Adam Davis <eadavis@qq.com>
Reported-and-tested-by: default avatar <syzbot+ae688d469e36fb5138d0@syzkaller.appspotmail.com>
Link: https://patch.msgid.link/tencent_BE7AEE6C7C2D216CB8949CE8E6EE7ECC2C0A@qq.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
parent 70dd7b57

fs/ext4/namei.c

+1 −1
Original line number Diff line number Diff line
@@ -1999,7 +1999,7 @@ static struct ext4_dir_entry_2 *do_split(handle_t *handle, struct inode *dir, 
		split = count/2;



	hash2 = map[split].hash;

	continued = hash2 == map[split - 1].hash;

	continued = split > 0 ? hash2 == map[split - 1].hash : 0;

	dxtrace(printk(KERN_INFO "Split block %lu at %x, %i/%i\n",

			(unsigned long)dx_get_block(frame->at),

					hash2, split, count-split));