Commit 1a367867 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

genirq/chip: Rework handle_simple_irq() 



Use the new helpers to decide whether the interrupt should be handled and
switch the descriptor locking to guard().

Fixup the kernel doc comment while at it.

No functional change.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065420.804683349@linutronix.de
parent 2ef2e130

kernel/irq/chip.c

+10 −20
Original line number Diff line number Diff line
@@ -542,31 +542,21 @@ EXPORT_SYMBOL_GPL(handle_nested_irq); 
 * @desc:	the interrupt description structure for this irq

 *

 * Simple interrupts are either sent from a demultiplexing interrupt

 *	handler or come from hardware, where no interrupt hardware control

 *	is necessary.

 * handler or come from hardware, where no interrupt hardware control is

 * necessary.

 *

 *	Note: The caller is expected to handle the ack, clear, mask and

 *	unmask issues if necessary.

 * Note: The caller is expected to handle the ack, clear, mask and unmask

 * issues if necessary.

 */

void handle_simple_irq(struct irq_desc *desc)

{

	raw_spin_lock(&desc->lock);



	if (!irq_can_handle_pm(desc))

		goto out_unlock;

	guard(raw_spinlock)(&desc->lock);



	desc->istate &= ~(IRQS_REPLAY | IRQS_WAITING);



	if (unlikely(!desc->action || irqd_irq_disabled(&desc->irq_data))) {

		desc->istate |= IRQS_PENDING;

		goto out_unlock;

	}

	if (!irq_can_handle(desc))

		return;



	kstat_incr_irqs_this_cpu(desc);

	handle_irq_event(desc);



out_unlock:

	raw_spin_unlock(&desc->lock);

}

EXPORT_SYMBOL_GPL(handle_simple_irq);