Commit 1a5cba43 authored by Mudit Sharma's avatar Mudit Sharma Committed by Jonathan Cameron
Browse files

iio: light: apds9306: Fix error handing 



The return value of 'iio_gts_find_int_time_by_sel()' is assigned to
variable 'intg_old' but value of 'ret' is checked for error. Update to
use 'intg_old' for error checking.

Fixes: 620d1e6c ("iio: light: Add support for APDS9306 Light Sensor")
Signed-off-by: default avatarMudit Sharma <muditsharma.info@gmail.com>
Reviewed-by: default avatarSubhajit Ghosh <subhajit.ghosh@tweaklogic.com>
Link: https://patch.msgid.link/20240625210203.522179-1-muditsharma.info@gmail.com


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 74cb2157

drivers/iio/light/apds9306.c

+2 −2
Original line number Diff line number Diff line
@@ -583,8 +583,8 @@ static int apds9306_intg_time_set(struct apds9306_data *data, int val2) 
		return ret;



	intg_old = iio_gts_find_int_time_by_sel(&data->gts, intg_time_idx);

	if (ret < 0)

		return ret;

	if (intg_old < 0)

		return intg_old;



	if (intg_old == val2)

		return 0;