Commit 1a685940 authored by Dongliang Mu's avatar Dongliang Mu Committed by Leon Romanovsky
Browse files

RDMA/rxe: fix xa_alloc_cycle() error return value check again 

Currently rxe_alloc checks ret to indicate error, but 1 is also a valid
return and just indicates that the allocation succeeded with a wrap.

Fix this by modifying the check to be < 0.

Link: https://lore.kernel.org/r/20220609070656.1446121-1-dzm91@hust.edu.cn


Fixes: 3225717f ("RDMA/rxe: Replace red-black trees by xarrays")
Signed-off-by: default avatarDongliang Mu <mudongliangabcd@gmail.com>
Reviewed-by: default avatarBob Pearson <rpearsonhpe@gmail.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent d56e336e

drivers/infiniband/sw/rxe/rxe_pool.c

+2 −2
Original line number Diff line number Diff line
@@ -139,7 +139,7 @@ void *rxe_alloc(struct rxe_pool *pool) 


	err = xa_alloc_cyclic(&pool->xa, &elem->index, elem, pool->limit,

			      &pool->next, GFP_KERNEL);

	if (err)

	if (err < 0)

		goto err_free;



	return obj;
@@ -167,7 +167,7 @@ int __rxe_add_to_pool(struct rxe_pool *pool, struct rxe_pool_elem *elem) 


	err = xa_alloc_cyclic(&pool->xa, &elem->index, elem, pool->limit,

			      &pool->next, GFP_KERNEL);

	if (err)

	if (err < 0)

		goto err_cnt;



	return 0;