Commit 1a7a7b80 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Douglas Anderson
Browse files

drm/panel: novatek-nt35560: avoid on-stack device structure 



A cleanup patch apparently by accident used a local device structure
instead of a pointer to one in the nt35560_read_id() function, causing
a warning about stack usage:

drivers/gpu/drm/panel/panel-novatek-nt35560.c: In function 'nt35560_read_id':
drivers/gpu/drm/panel/panel-novatek-nt35560.c:249:1: error: the frame size of 1296 bytes is larger than 1280 bytes [-Werror=frame-larger-than=]

Change this to a pointer as was liley intended here.

Fixes: 5fbc0dbb ("drm/panel: novatek-nt35560: Clean up driver")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://patch.msgid.link/20251204094550.1030506-1-arnd@kernel.org
parent eb76d0f5

drivers/gpu/drm/panel/panel-novatek-nt35560.c

+4 −4
Original line number Diff line number Diff line
@@ -213,7 +213,7 @@ static const struct backlight_properties nt35560_bl_props = { 


static void nt35560_read_id(struct mipi_dsi_multi_context *dsi_ctx)

{

	struct device dev = dsi_ctx->dsi->dev;

	struct device *dev = &dsi_ctx->dsi->dev;

	u8 vendor, version, panel;

	u16 val;
@@ -225,7 +225,7 @@ static void nt35560_read_id(struct mipi_dsi_multi_context *dsi_ctx) 
		return;



	if (vendor == 0x00) {

		dev_err(&dev, "device vendor ID is zero\n");

		dev_err(dev, "device vendor ID is zero\n");

		dsi_ctx->accum_err = -ENODEV;

		return;

	}
@@ -236,12 +236,12 @@ static void nt35560_read_id(struct mipi_dsi_multi_context *dsi_ctx) 
	case DISPLAY_SONY_ACX424AKP_ID2:

	case DISPLAY_SONY_ACX424AKP_ID3:

	case DISPLAY_SONY_ACX424AKP_ID4:

		dev_info(&dev,

		dev_info(dev,

			 "MTP vendor: %02x, version: %02x, panel: %02x\n",

			 vendor, version, panel);

		break;

	default:

		dev_info(&dev,

		dev_info(dev,

			 "unknown vendor: %02x, version: %02x, panel: %02x\n",

			 vendor, version, panel);

		break;