Commit 1a8d4c6e authored by Haoxiang Li's avatar Haoxiang Li Committed by Thomas Gleixner
Browse files

PCI/MSI: Unmap MSI-X region on error 



msix_capability_init() fails to unmap the MSI-X region if
msix_setup_interrupts() fails.

Add the missing iounmap() for that error path.

[ tglx: Massaged change log ]

Signed-off-by: default avatarHaoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Signed-off-by: default avatarThomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260125144452.2103812-1-lihaoxiang@isrc.iscas.ac.cn
parent df439718

drivers/pci/msi/msi.c

+3 −1
Original line number Diff line number Diff line
@@ -737,7 +737,7 @@ static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries, 


	ret = msix_setup_interrupts(dev, entries, nvec, affd);

	if (ret)

		goto out_disable;

		goto out_unmap;



	/* Disable INTX */

	pci_intx_for_msi(dev, 0);
@@ -758,6 +758,8 @@ static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries, 
	pcibios_free_irq(dev);

	return 0;



out_unmap:

	iounmap(dev->msix_base);

out_disable:

	dev->msix_enabled = 0;

	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL | PCI_MSIX_FLAGS_ENABLE, 0);