Commit 1aa6e256 authored by Sean Christopherson's avatar Sean Christopherson
Browse files

KVM: SVM: Inhibit AVIC if ID is too big instead of rejecting vCPU creation 



Inhibit AVIC with a new "ID too big" flag if userspace creates a vCPU with
an ID that is too big, but otherwise allow vCPU creation to succeed.
Rejecting KVM_CREATE_VCPU with EINVAL violates KVM's ABI as KVM advertises
that the max vCPU ID is 4095, but disallows creating vCPUs with IDs bigger
than 254 (AVIC) or 511 (x2AVIC).

Alternatively, KVM could advertise an accurate value depending on which
AVIC mode is in use, but that wouldn't really solve the underlying problem,
e.g. would be a breaking change if KVM were to ever try and enable AVIC or
x2AVIC by default.

Cc: Maxim Levitsky <mlevitsk@redhat.com>
Tested-by: default avatarSairaj Kodilkar <sarunkod@amd.com>
Link: https://lore.kernel.org/r/20250611224604.313496-14-seanjc@google.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent d8527f13

arch/x86/include/asm/kvm_host.h

+8 −1
Original line number Diff line number Diff line
@@ -1315,6 +1315,12 @@ enum kvm_apicv_inhibit { 
	 */

	APICV_INHIBIT_REASON_LOGICAL_ID_ALIASED,



	/*

	 * AVIC is disabled because the vCPU's APIC ID is beyond the max

	 * supported by AVIC/x2AVIC, i.e. the vCPU is unaddressable.

	 */

	APICV_INHIBIT_REASON_PHYSICAL_ID_TOO_BIG,



	NR_APICV_INHIBIT_REASONS,

};
@@ -1333,7 +1339,8 @@ enum kvm_apicv_inhibit { 
	__APICV_INHIBIT_REASON(IRQWIN),			\

	__APICV_INHIBIT_REASON(PIT_REINJ),		\

	__APICV_INHIBIT_REASON(SEV),			\

	__APICV_INHIBIT_REASON(LOGICAL_ID_ALIASED)

	__APICV_INHIBIT_REASON(LOGICAL_ID_ALIASED),	\

	__APICV_INHIBIT_REASON(PHYSICAL_ID_TOO_BIG)



struct kvm_arch {

	unsigned long n_used_mmu_pages;

arch/x86/kvm/svm/avic.c

+12 −2
Original line number Diff line number Diff line
@@ -278,9 +278,19 @@ static int avic_init_backing_page(struct kvm_vcpu *vcpu) 
	int id = vcpu->vcpu_id;

	struct vcpu_svm *svm = to_svm(vcpu);



	/*

	 * Inhibit AVIC if the vCPU ID is bigger than what is supported by AVIC

	 * hardware.  Immediately clear apicv_active, i.e. don't wait until the

	 * KVM_REQ_APICV_UPDATE request is processed on the first KVM_RUN, as

	 * avic_vcpu_load() expects to be called if and only if the vCPU has

	 * fully initialized AVIC.

	 */

	if ((!x2avic_enabled && id > AVIC_MAX_PHYSICAL_ID) ||

	    (id > X2AVIC_MAX_PHYSICAL_ID))

		return -EINVAL;

	    (id > X2AVIC_MAX_PHYSICAL_ID)) {

		kvm_set_apicv_inhibit(vcpu->kvm, APICV_INHIBIT_REASON_PHYSICAL_ID_TOO_BIG);

		vcpu->arch.apic->apicv_active = false;

		return 0;

	}



	if (WARN_ON_ONCE(!vcpu->arch.apic->regs))

		return -EINVAL;

arch/x86/kvm/svm/svm.h

+2 −1
Original line number Diff line number Diff line
@@ -722,7 +722,8 @@ extern struct kvm_x86_nested_ops svm_nested_ops; 
	BIT(APICV_INHIBIT_REASON_PHYSICAL_ID_ALIASED) |	\

	BIT(APICV_INHIBIT_REASON_APIC_ID_MODIFIED) |	\

	BIT(APICV_INHIBIT_REASON_APIC_BASE_MODIFIED) |	\

	BIT(APICV_INHIBIT_REASON_LOGICAL_ID_ALIASED)	\

	BIT(APICV_INHIBIT_REASON_LOGICAL_ID_ALIASED) |	\

	BIT(APICV_INHIBIT_REASON_PHYSICAL_ID_TOO_BIG)	\

)



bool avic_hardware_setup(void);