Commit 1ab8e268 authored Mar 30, 2021 by Lee Jones Committed by Tyler Hicks Apr 19, 2021

ecryptfs: messaging: Add missing param descriptions and demote abuses

Fixes the following W=1 kernel build warning(s):

fs/ecryptfs/messaging.c:15: warning: Function parameter or member 'ecryptfs_msg_ctx_free_list' not described in 'LIST_HEAD'
fs/ecryptfs/messaging.c:15: warning: expecting prototype for eCryptfs(). Prototype was for LIST_HEAD() instead
fs/ecryptfs/messaging.c:157: warning: Function parameter or member 'daemon' not described in 'ecryptfs_exorcise_daemon'
fs/ecryptfs/messaging.c:207: warning: Function parameter or member 'daemon' not described in 'ecryptfs_process_response'
fs/ecryptfs/messaging.c:207: warning: expecting prototype for ecryptfs_process_reponse(). Prototype was for ecryptfs_process_response() instead
fs/ecryptfs/messaging.c:262: warning: Function parameter or member 'msg_type' not described in 'ecryptfs_send_message_locked'

Cc: Tyler Hicks <code@tyhicks.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Waiman Long <longman@redhat.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: "Michael A. Halcrow" <mhalcrow@us.ibm.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Tyler Hicks <code@tyhicks.com>

parent 1c6675ca

fs/ecryptfs/messaging.c

+5 −3

Original line number	Diff line number	Diff line
		// SPDX-License-Identifier: GPL-2.0-only
		/**
		/*
		* eCryptfs: Linux filesystem encryption layer
		*
		* Copyright (C) 2004-2008 International Business Machines Corp.
		@@ -147,7 +147,7 @@ ecryptfs_spawn_daemon(struct ecryptfs_daemon *daemon, struct file file)
		return rc;
		}

		/**
		/*
		* ecryptfs_exorcise_daemon - Destroy the daemon struct
		*
		* Must be called ceremoniously while in possession of
		@@ -181,7 +181,8 @@ int ecryptfs_exorcise_daemon(struct ecryptfs_daemon *daemon)
		}

		/**
		* ecryptfs_process_reponse
		* ecryptfs_process_response
		* @daemon: eCryptfs daemon object
		* @msg: The ecryptfs message received; the caller should sanity check
		* msg->data_len and free the memory
		* @seq: The sequence number of the message; must match the sequence
		@@ -250,6 +251,7 @@ int ecryptfs_process_response(struct ecryptfs_daemon *daemon,
		* ecryptfs_send_message_locked
		* @data: The data to send
		* @data_len: The length of data
		* @msg_type: Type of message
		* @msg_ctx: The message context allocated for the send
		*
		* Must be called with ecryptfs_daemon_hash_mux held.