Commit 1ac6f60a authored by Johannes Berg's avatar Johannes Berg
Browse files

wifi: mac80211: mlme: fix memory leak 



When re-parsing the elements here (with changed mode), free
the original ones first to avoid leaking memory.

Fixes: 310c8387 ("wifi: mac80211: clean up connection process")
Reviewed-by: default avatarMiriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://msgid.link/20240418105220.458421e3bbff.Icb5b84cba3ea420794cf009cf18ec3d76e434736@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 645acc6f

net/mac80211/mlme.c

+3 −1
Original line number Diff line number Diff line
@@ -753,8 +753,10 @@ ieee80211_determine_chan_mode(struct ieee80211_sub_if_data *sdata, 
	}



	/* the mode can only decrease, so this must terminate */

	if (ap_mode != conn->mode)

	if (ap_mode != conn->mode) {

		kfree(elems);

		goto again;

	}



	mlme_link_id_dbg(sdata, link_id,

			 "connecting with %s mode, max bandwidth %d MHz\n",