Commit 1ad5dc35 authored by Jarkko Nikula's avatar Jarkko Nikula Committed by Wolfram Sang
Browse files

i2c: i801: Fix incorrect and needless software PEC disabling 



Commit a6b8bb6a ("i2c: i801: Fix handling SMBHSTCNT_PEC_EN")
attempts to disable software PEC by clearing the SMBHSTCNT_PEC_EN (bit 7)
in the SMBus Host Control register (I/O SMBHSTCNT) but incorrectly
clears it in the PCI Host Configuration register (PCI SMBHSTCFG).

This clearing is actually needless since after above commit the
SMBHSTCNT_PEC_EN is never set and the register is initialized with known
values.

Signed-off-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent cc28e578

drivers/i2c/busses/i2c-i801.c

+0 −1
Original line number Diff line number Diff line
@@ -1657,7 +1657,6 @@ static void i801_setup_hstcfg(struct i801_priv *priv) 
	unsigned char hstcfg = priv->original_hstcfg;



	hstcfg &= ~SMBHSTCFG_I2C_EN;	/* SMBus timing */

	hstcfg &= ~SMBHSTCNT_PEC_EN;	/* Disable software PEC */

	hstcfg |= SMBHSTCFG_HST_EN;

	pci_write_config_byte(priv->pci_dev, SMBHSTCFG, hstcfg);

}