Commit 1b0cbcf8 authored by Alex Hung's avatar Alex Hung Committed by Alex Deucher
Browse files

drm/amd/display: Fix uninitialized variables in amdgpu_dm_debugfs 



[WHAT]
Some fields in struct dc_link_settings and link_training_settings are
not initialized and using them can cause unexpected results.

[HOW]
Initialize struct dc_link_settings and link_training_settings to zero.

Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Reviewed-by: default avatarRodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: default avatarAlex Hung <alex.hung@amd.com>
Signed-off-by: default avatarRodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 57a793a7

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c

+4 −4
Original line number Diff line number Diff line
@@ -258,7 +258,7 @@ static ssize_t dp_link_settings_write(struct file *f, const char __user *buf, 
	struct dc_link *link = connector->dc_link;

	struct amdgpu_device *adev = drm_to_adev(connector->base.dev);

	struct dc *dc = (struct dc *)link->dc;

	struct dc_link_settings prefer_link_settings;

	struct dc_link_settings prefer_link_settings = {0};

	char *wr_buf = NULL;

	const uint32_t wr_buf_size = 40;

	/* 0: lane_count; 1: link_rate */
@@ -389,7 +389,7 @@ static ssize_t dp_mst_link_setting(struct file *f, const char __user *buf, 
	struct dc_link *link = aconnector->dc_link;

	struct amdgpu_device *adev = drm_to_adev(aconnector->base.dev);

	struct dc *dc = (struct dc *)link->dc;

	struct dc_link_settings prefer_link_settings;

	struct dc_link_settings prefer_link_settings = {0};

	char *wr_buf = NULL;

	const uint32_t wr_buf_size = 40;

	/* 0: lane_count; 1: link_rate */
@@ -613,7 +613,7 @@ static ssize_t dp_phy_settings_write(struct file *f, const char __user *buf, 
	uint32_t wr_buf_size = 40;

	long param[3];

	bool use_prefer_link_setting;

	struct link_training_settings link_lane_settings;

	struct link_training_settings link_lane_settings = {0};

	int max_param_num = 3;

	uint8_t param_nums = 0;

	int r = 0;
@@ -768,7 +768,7 @@ static ssize_t dp_phy_test_pattern_debugfs_write(struct file *f, const char __us 
			LINK_RATE_UNKNOWN, LINK_SPREAD_DISABLED};

	struct dc_link_settings cur_link_settings = {LANE_COUNT_UNKNOWN,

			LINK_RATE_UNKNOWN, LINK_SPREAD_DISABLED};

	struct link_training_settings link_training_settings;

	struct link_training_settings link_training_settings = {0};

	int i;



	if (size == 0)