Commit 1b926914 authored by Cosmin Tanislav's avatar Cosmin Tanislav Committed by Jonathan Cameron
Browse files

iio: accel: adxl367: fix DEVID read after reset 



regmap_read_poll_timeout() will not sleep before reading,
causing the first read to return -ENXIO on I2C, since the
chip does not respond to it while it is being reset.

The datasheet specifies that a soft reset operation has a
latency of 7.5ms.

Add a 15ms sleep between reset and reading the DEVID register,
and switch to a simple regmap_read() call.

Fixes: cbab791c ("iio: accel: add ADXL367 driver")
Signed-off-by: default avatarCosmin Tanislav <demonsingur@gmail.com>
Reviewed-by: default avatarNuno Sa <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20240207033657.206171-1-demonsingur@gmail.com


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent a1c9f508

drivers/iio/accel/adxl367.c

+6 −2
Original line number Diff line number Diff line
@@ -1429,9 +1429,11 @@ static int adxl367_verify_devid(struct adxl367_state *st) 
	unsigned int val;

	int ret;



	ret = regmap_read_poll_timeout(st->regmap, ADXL367_REG_DEVID, val,

				       val == ADXL367_DEVID_AD, 1000, 10000);

	ret = regmap_read(st->regmap, ADXL367_REG_DEVID, &val);

	if (ret)

		return dev_err_probe(st->dev, ret, "Failed to read dev id\n");



	if (val != ADXL367_DEVID_AD)

		return dev_err_probe(st->dev, -ENODEV,

				     "Invalid dev id 0x%02X, expected 0x%02X\n",

				     val, ADXL367_DEVID_AD);
@@ -1510,6 +1512,8 @@ int adxl367_probe(struct device *dev, const struct adxl367_ops *ops, 
	if (ret)

		return ret;



	fsleep(15000);



	ret = adxl367_verify_devid(st);

	if (ret)

		return ret;