Commit 1b9c17fd authored Jan 21, 2026 by Jianpeng Chang Committed by Luiz Augusto von Dentz Jan 22, 2026

Bluetooth: MGMT: Fix memory leak in set_ssp_complete

Fix memory leak in set_ssp_complete() where mgmt_pending_cmd structures
are not freed after being removed from the pending list.

Commit 302a1f67 ("Bluetooth: MGMT: Fix possible UAFs") replaced
mgmt_pending_foreach() calls with individual command handling but missed
adding mgmt_pending_free() calls in both error and success paths of
set_ssp_complete(). Other completion functions like set_le_complete()
were fixed correctly in the same commit.

This causes a memory leak of the mgmt_pending_cmd structure and its
associated parameter data for each SSP command that completes.

Add the missing mgmt_pending_free(cmd) calls in both code paths to fix
the memory leak. Also fix the same issue in set_advertising_complete().

Fixes: 302a1f67 ("Bluetooth: MGMT: Fix possible UAFs")
Signed-off-by: Jianpeng Chang <jianpeng.chang.cn@windriver.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

parent 0c3cd7a0

net/bluetooth/mgmt.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1966,6 +1966,7 @@ static void set_ssp_complete(struct hci_dev hdev, void data, int err)
		}

		mgmt_cmd_status(cmd->sk, cmd->hdev->id, cmd->opcode, mgmt_err);
		mgmt_pending_free(cmd);
		return;
		}

		@@ -1984,6 +1985,7 @@ static void set_ssp_complete(struct hci_dev hdev, void data, int err)
		sock_put(match.sk);

		hci_update_eir_sync(hdev);
		mgmt_pending_free(cmd);
		}

		static int set_ssp_sync(struct hci_dev hdev, void data)
		@@ -6438,6 +6440,7 @@ static void set_advertising_complete(struct hci_dev hdev, void data, int err)
		hci_dev_clear_flag(hdev, HCI_ADVERTISING);

		settings_rsp(cmd, &match);
		mgmt_pending_free(cmd);

		new_settings(hdev, match.sk);