Commit 1c05bf6c authored by Hugo Villeneuve's avatar Hugo Villeneuve Committed by Greg Kroah-Hartman
Browse files

serial: sc16is7xx: remove useless enable of enhanced features 



Commit 43c51bb5 ("sc16is7xx: make sure device is in suspend once
probed") permanently enabled access to the enhanced features in
sc16is7xx_probe(), and it is never disabled after that.

Therefore, remove re-enable of enhanced features in
sc16is7xx_set_baud(). This eliminates a potential useless read + write
cycle each time the baud rate is reconfigured.

Fixes: 43c51bb5 ("sc16is7xx: make sure device is in suspend once probed")
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarHugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://patch.msgid.link/20251006142002.177475-1-hugo@hugovil.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e7cbce76

drivers/tty/serial/sc16is7xx.c

+0 −7
Original line number Diff line number Diff line
@@ -588,13 +588,6 @@ static int sc16is7xx_set_baud(struct uart_port *port, int baud) 
		div /= prescaler;

	}



	/* Enable enhanced features */

	sc16is7xx_efr_lock(port);

	sc16is7xx_port_update(port, SC16IS7XX_EFR_REG,

			      SC16IS7XX_EFR_ENABLE_BIT,

			      SC16IS7XX_EFR_ENABLE_BIT);

	sc16is7xx_efr_unlock(port);



	/* If bit MCR_CLKSEL is set, the divide by 4 prescaler is activated. */

	sc16is7xx_port_update(port, SC16IS7XX_MCR_REG,

			      SC16IS7XX_MCR_CLKSEL_BIT,