Commit 1c2958e4 authored by Kuniyuki Iwashima's avatar Kuniyuki Iwashima Committed by Martin KaFai Lau
Browse files

bpf: tcp: Fix type confusion in sol_tcp_sockopt(). 



sol_tcp_sockopt() only checks if sk->sk_protocol is IPPROTO_TCP,
but RAW socket can bypass it:

  socket(AF_INET, SOCK_RAW, IPPROTO_TCP)

Let's use sk_is_tcp().

Note that initially sol_tcp_sockopt() checked sk->sk_prot->setsockopt.

Fixes: 2ab42c7b ("bpf: Check the protocol of a sock to agree the calls to bpf_setsockopt().")
Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@google.com>
Signed-off-by: default avatarMartin KaFai Lau <martin.lau@kernel.org>
Link: https://patch.msgid.link/20260504210610.180150-7-kuniyu@google.com
parent 843064b0

net/core/filter.c

+1 −1
Original line number Diff line number Diff line
@@ -5481,7 +5481,7 @@ static int sol_tcp_sockopt(struct sock *sk, int optname, 
			   char *optval, int *optlen,

			   bool getopt)

{

	if (sk->sk_protocol != IPPROTO_TCP)

	if (!sk_is_tcp(sk))

		return -EINVAL;



	switch (optname) {