Commit 1c3329df authored by Frederic Weisbecker's avatar Frederic Weisbecker
Browse files

sched/isolation: Remove HK_TYPE_TICK test from cpu_is_isolated() 



It doesn't make sense to use nohz_full without also isolating the
related CPUs from the domain topology, either through the use of
isolcpus= or cpuset isolated partitions.

And now HK_TYPE_DOMAIN includes all kinds of domain isolated CPUs.

This means that HK_TYPE_DOMAIN should always be a subset of
HK_TYPE_KERNEL_NOISE (of which HK_TYPE_TICK is only an alias).

Therefore if a CPU is not HK_TYPE_DOMAIN, it shouldn't be
HK_TYPE_KERNEL_NOISE either. Testing the former is then enough.

Simplify cpu_is_isolated() accordingly.

Signed-off-by: default avatarFrederic Weisbecker <frederic@kernel.org>
Acked-by: default avatarWaiman Long <longman@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Marco Crivellari <marco.crivellari@suse.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Waiman Long <longman@redhat.com>
parent 64409660

include/linux/sched/isolation.h

+1 −2
Original line number Diff line number Diff line
@@ -82,8 +82,7 @@ static inline bool housekeeping_cpu(int cpu, enum hk_type type) 


static inline bool cpu_is_isolated(int cpu)

{

	return !housekeeping_test_cpu(cpu, HK_TYPE_DOMAIN) ||

	       !housekeeping_test_cpu(cpu, HK_TYPE_TICK);

	return !housekeeping_test_cpu(cpu, HK_TYPE_DOMAIN);

}



#endif /* _LINUX_SCHED_ISOLATION_H */