Commit 1c679926 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Linus Walleij
Browse files

pinctrl: ocelot: Constify some structures 



'struct ocelot_match_data and 'struct irq_chip' are not modified in this
driver.

Constifying these structures moves some data to a read-only section, so
increase overall security, especially when the structure holds some
function pointers.

On a x86_64, with allmodconfig:
Before:
======
   text	   data	    bss	    dec	    hex	filename
  41459	   9008	     80	  50547	   c573	drivers/pinctrl/pinctrl-ocelot.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
  42803	   7640	     80	  50523	   c55b	drivers/pinctrl/pinctrl-ocelot.o

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/32edcf0567fffd0b1a219e7e2dad7e0bd8c5aaf4.1734023550.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent fa4752d4

drivers/pinctrl/pinctrl-ocelot.c

+10 −10
Original line number Diff line number Diff line
@@ -1777,7 +1777,7 @@ static const struct pinctrl_ops ocelot_pctl_ops = { 
	.dt_free_map = pinconf_generic_dt_free_map,

};



static struct ocelot_match_data luton_desc = {

static const struct ocelot_match_data luton_desc = {

	.desc = {

		.name = "luton-pinctrl",

		.pins = luton_pins,
@@ -1788,7 +1788,7 @@ static struct ocelot_match_data luton_desc = { 
	},

};



static struct ocelot_match_data serval_desc = {

static const struct ocelot_match_data serval_desc = {

	.desc = {

		.name = "serval-pinctrl",

		.pins = serval_pins,
@@ -1799,7 +1799,7 @@ static struct ocelot_match_data serval_desc = { 
	},

};



static struct ocelot_match_data ocelot_desc = {

static const struct ocelot_match_data ocelot_desc = {

	.desc = {

		.name = "ocelot-pinctrl",

		.pins = ocelot_pins,
@@ -1810,7 +1810,7 @@ static struct ocelot_match_data ocelot_desc = { 
	},

};



static struct ocelot_match_data jaguar2_desc = {

static const struct ocelot_match_data jaguar2_desc = {

	.desc = {

		.name = "jaguar2-pinctrl",

		.pins = jaguar2_pins,
@@ -1821,7 +1821,7 @@ static struct ocelot_match_data jaguar2_desc = { 
	},

};



static struct ocelot_match_data servalt_desc = {

static const struct ocelot_match_data servalt_desc = {

	.desc = {

		.name = "servalt-pinctrl",

		.pins = servalt_pins,
@@ -1832,7 +1832,7 @@ static struct ocelot_match_data servalt_desc = { 
	},

};



static struct ocelot_match_data sparx5_desc = {

static const struct ocelot_match_data sparx5_desc = {

	.desc = {

		.name = "sparx5-pinctrl",

		.pins = sparx5_pins,
@@ -1850,7 +1850,7 @@ static struct ocelot_match_data sparx5_desc = { 
	},

};



static struct ocelot_match_data lan966x_desc = {

static const struct ocelot_match_data lan966x_desc = {

	.desc = {

		.name = "lan966x-pinctrl",

		.pins = lan966x_pins,
@@ -1867,7 +1867,7 @@ static struct ocelot_match_data lan966x_desc = { 
	},

};



static struct ocelot_match_data lan969x_desc = {

static const struct ocelot_match_data lan969x_desc = {

	.desc = {

		.name = "lan969x-pinctrl",

		.pins = lan969x_pins,
@@ -2116,7 +2116,7 @@ static void ocelot_irq_ack(struct irq_data *data) 


static int ocelot_irq_set_type(struct irq_data *data, unsigned int type);



static struct irq_chip ocelot_level_irqchip = {

static const struct irq_chip ocelot_level_irqchip = {

	.name		= "gpio",

	.irq_mask	= ocelot_irq_mask,

	.irq_ack	= ocelot_irq_ack,
@@ -2126,7 +2126,7 @@ static struct irq_chip ocelot_level_irqchip = { 
	GPIOCHIP_IRQ_RESOURCE_HELPERS

};



static struct irq_chip ocelot_irqchip = {

static const struct irq_chip ocelot_irqchip = {

	.name		= "gpio",

	.irq_mask	= ocelot_irq_mask,

	.irq_ack	= ocelot_irq_ack,