Commit 1cb394e6 authored by Uwe Kleine-König's avatar Uwe Kleine-König
Browse files

gpu: host1x: mipi: Benefit from devm_clk_get_prepared() 



When using devm_clk_get_prepared() instead of devm_clk_get() the clock
is already returned prepared. So probe doesn't need to call
clk_prepare() and at remove time the call to clk_unprepare() can be
dropped. The latter makes the remove callback empty, so it can be
dropped, too.

Acked-by: default avatarThierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20240409165043.105137-2-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
parent 49fc3ffe

drivers/gpu/host1x/mipi.c

+1 −16
Original line number Diff line number Diff line
@@ -501,7 +501,6 @@ static int tegra_mipi_probe(struct platform_device *pdev) 
{

	const struct of_device_id *match;

	struct tegra_mipi *mipi;

	int err;



	match = of_match_node(tegra_mipi_of_match, pdev->dev.of_node);

	if (!match)
@@ -520,35 +519,21 @@ static int tegra_mipi_probe(struct platform_device *pdev) 


	mutex_init(&mipi->lock);



	mipi->clk = devm_clk_get(&pdev->dev, NULL);

	mipi->clk = devm_clk_get_prepared(&pdev->dev, NULL);

	if (IS_ERR(mipi->clk)) {

		dev_err(&pdev->dev, "failed to get clock\n");

		return PTR_ERR(mipi->clk);

	}



	err = clk_prepare(mipi->clk);

	if (err < 0)

		return err;



	platform_set_drvdata(pdev, mipi);



	return 0;

}



static int tegra_mipi_remove(struct platform_device *pdev)

{

	struct tegra_mipi *mipi = platform_get_drvdata(pdev);



	clk_unprepare(mipi->clk);



	return 0;

}



struct platform_driver tegra_mipi_driver = {

	.driver = {

		.name = "tegra-mipi",

		.of_match_table = tegra_mipi_of_match,

	},

	.probe = tegra_mipi_probe,

	.remove = tegra_mipi_remove,

};