Commit 1cbf0a58 authored by Hugh Dickins's avatar Hugh Dickins Committed by Andrew Morton
Browse files

ext4: add __GFP_NOWARN to GFP_NOWAIT in readahead 

Since commit e509ad4d ("ext4: use bdev_getblk() to avoid memory
reclaim in readahead path") rightly replaced GFP_NOFAIL allocations by
GFP_NOWAIT allocations, I've occasionally been seeing "page allocation
failure: order:0" warnings under load: all with
ext4_sb_breadahead_unmovable() in the stack.  I don't think those warnings
are of any interest: suppress them with __GFP_NOWARN.

Link: https://lkml.kernel.org/r/7bc6ad16-9a4d-dd90-202e-47d6cbb5a136@google.com


Fixes: e509ad4d ("ext4: use bdev_getblk() to avoid memory reclaim in readahead path")
Signed-off-by: default avatarHugh Dickins <hughd@google.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Cc: Hui Zhu <teawater@antgroup.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent eebb3dab

fs/ext4/super.c

+1 −1
Original line number Diff line number Diff line
@@ -262,7 +262,7 @@ struct buffer_head *ext4_sb_bread_unmovable(struct super_block *sb, 
void ext4_sb_breadahead_unmovable(struct super_block *sb, sector_t block)

{

	struct buffer_head *bh = bdev_getblk(sb->s_bdev, block,

			sb->s_blocksize, GFP_NOWAIT);

			sb->s_blocksize, GFP_NOWAIT | __GFP_NOWARN);



	if (likely(bh)) {

		if (trylock_buffer(bh))