Commit 1cc4cdae authored by Keith Busch's avatar Keith Busch
Browse files

nvme-pci: fix missed admin queue sq doorbell write 



We can batch admin commands submitted through io_uring_cmd passthrough,
which means bd->last may be false and skips the doorbell write to
aggregate multiple commands per write. If a subsequent command can't be
dispatched for whatever reason, we have to provide the blk-mq ops'
commit_rqs callback in order to ensure we properly update the doorbell.

Fixes: 58e5bdeb ("nvme: enable uring-passthrough for admin commands")
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarKanchan Joshi <joshi.k@samsung.com>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 5d10069e

drivers/nvme/host/pci.c

+1 −0
Original line number Diff line number Diff line
@@ -2239,6 +2239,7 @@ static int nvme_create_queue(struct nvme_queue *nvmeq, int qid, bool polled) 
static const struct blk_mq_ops nvme_mq_admin_ops = {

	.queue_rq	= nvme_queue_rq,

	.complete	= nvme_pci_complete_rq,

	.commit_rqs	= nvme_commit_rqs,

	.init_hctx	= nvme_admin_init_hctx,

	.init_request	= nvme_pci_init_request,

	.timeout	= nvme_timeout,