Commit 1ccc00d7 authored by Thorsten Blum's avatar Thorsten Blum Committed by Herbert Xu
Browse files

crypto: engine - Use unregister_* in register_{aeads,ahashes,skciphers} 



Replace the for loops with calls to unregister_aeads(),
unregister_ahashes(), and unregister_skciphers(), respectively. Return
'ret' immediately and remove the goto statements to simplify the error
handling code.  No functional changes.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 32adff68

crypto/crypto_engine.c

+12 −21
Original line number Diff line number Diff line
@@ -524,16 +524,13 @@ int crypto_engine_register_aeads(struct aead_engine_alg *algs, int count) 


	for (i = 0; i < count; i++) {

		ret = crypto_engine_register_aead(&algs[i]);

		if (ret)

			goto err;

		if (ret) {

			crypto_engine_unregister_aeads(algs, i);

			return ret;

		}

	}



	return 0;



err:

	crypto_engine_unregister_aeads(algs, i);



	return ret;

}

EXPORT_SYMBOL_GPL(crypto_engine_register_aeads);
@@ -566,16 +563,13 @@ int crypto_engine_register_ahashes(struct ahash_engine_alg *algs, int count) 


	for (i = 0; i < count; i++) {

		ret = crypto_engine_register_ahash(&algs[i]);

		if (ret)

			goto err;

		if (ret) {

			crypto_engine_unregister_ahashes(algs, i);

			return ret;

		}

	}



	return 0;



err:

	crypto_engine_unregister_ahashes(algs, i);



	return ret;

}

EXPORT_SYMBOL_GPL(crypto_engine_register_ahashes);
@@ -638,16 +632,13 @@ int crypto_engine_register_skciphers(struct skcipher_engine_alg *algs, 


	for (i = 0; i < count; i++) {

		ret = crypto_engine_register_skcipher(&algs[i]);

		if (ret)

			goto err;

		if (ret) {

			crypto_engine_unregister_skciphers(algs, i);

			return ret;

		}

	}



	return 0;



err:

	crypto_engine_unregister_skciphers(algs, i);



	return ret;

}

EXPORT_SYMBOL_GPL(crypto_engine_register_skciphers);